🐛 Adjust custom target edit to reflect api changes #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
custom-target-form
branch
from
3a16c34
to
bbbb61e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage 40.29% 40.29%
=======================================
Files 143 143
Lines 4532 4532
Branches 1096 1096
=======================================
Hits 1826 1826
Misses 2609 2609
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ibolton336
force-pushed
the
custom-target-form
branch
from
bd94ea5
to
43f9d4a
Compare
sjd78
approved these changes
Oct 26, 2023
| tooltipMessage={ | ||
| "Cannot delete credential assigned to a JIRA tracker." | ||
| "Cannot delete credential as it is currently in use." |
There was a problem hiding this comment.
Suggested improvement: Add the name of the thing that is using the credential so it is easy to find.
"Credential is in use by application Foxtrot Oscar and cannot be deleted."
Signed-off-by: ibolton336 <ibolton@redhat.com>
Signed-off-by: ibolton336 <ibolton@redhat.com>
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
custom-target-form
branch
from
891d936
to
5ac2206
Compare
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-1542
https://issues.redhat.com/browse/MTA-1543