Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 adding some pf5 select wrappers #1490

Merged

Conversation

gitdallas
Copy link
Collaborator

effort towards #1242

pushing a couple new components without any changes to other stuff yet so ian can use one with something he is working on.

Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
@gitdallas gitdallas force-pushed the chore/1242-replace-dep-simple-select branch from 1e2a9ea to b129ae1 Compare October 26, 2023 20:11
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ed39248) 40.28% compared to head (b129ae1) 40.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1490   +/-   ##
=======================================
  Coverage   40.28%   40.29%           
=======================================
  Files         143      143           
  Lines        4530     4532    +2     
  Branches     1112     1096   -16     
=======================================
+ Hits         1825     1826    +1     
- Misses       2608     2609    +1     
  Partials       97       97           
Flag Coverage Δ
client 40.29% <42.85%> (+<0.01%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/components/SimpleSelect.tsx 100.00% <100.00%> (ø)
client/src/app/layout/SidebarApp/SidebarApp.tsx 26.66% <ø> (ø)
...s/components/application-form/application-form.tsx 65.95% <29.41%> (-0.36%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitdallas gitdallas merged commit bd5a4b0 into konveyor:main Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants