Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix layout bug on row click (intermittent) #1518

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ibolton336
Copy link
Member

  • Addresses an issue with the drawer click functionality which occurs when clicking in-between the columns on a table. The entire layout is left in an unrecoverable state.
Screen.Recording.2023-11-06.at.11.47.25.AM.mov

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93bb366) 40.80% compared to head (7c2d6ce) 40.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
+ Coverage   40.80%   40.82%   +0.01%     
==========================================
  Files         145      145              
  Lines        4578     4576       -2     
  Branches     1073     1073              
==========================================
  Hits         1868     1868              
+ Misses       2698     2696       -2     
  Partials       12       12              
Flag Coverage Δ
client 40.82% <ø> (+0.01%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/components/PageDrawerContext.tsx 18.36% <ø> (+0.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe worth commenting out the entire useEffect as it won't be doing anything... not that anyone would notice a performance hit i guess..

Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants