Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 UX improvements for app assessment/review discard #1525

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Nov 8, 2023

  • Resolves https://issues.redhat.com/browse/MTA-1611
  • Add tooltip to indicate review completed for ARCHETYPE.
  • Break up delete for reviews /assessments into two separate options for applications table actions column.
  • Invalidate assessments by AppId when fetching apps to fix stale assessment status post-assessmentDelete from the app table.
  • Add discard assessment & discard review options for archetype page.

@ibolton336 ibolton336 marked this pull request as draft November 8, 2023 19:37
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2af8077) 40.52% compared to head (2c066a6) 40.65%.

❗ Current head 2c066a6 differs from pull request most recent head 18ab44a. Consider uploading reports for the commit 18ab44a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
+ Coverage   40.52%   40.65%   +0.12%     
==========================================
  Files         145      145              
  Lines        4622     4615       -7     
  Branches     1084     1077       -7     
==========================================
+ Hits         1873     1876       +3     
+ Misses       2735     2725      -10     
  Partials       14       14              
Flag Coverage Δ
client 40.65% <44.44%> (+0.12%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/queries/applications.ts 33.04% <100.00%> (+0.58%) ⬆️
client/src/app/queries/archetypes.ts 24.44% <28.57%> (+0.76%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ibolton336 <ibolton@redhat.com>
Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 force-pushed the app-actions-discard-review-fix branch from 0b34b8b to 56fc0e9 Compare November 8, 2023 19:56
@ibolton336 ibolton336 changed the title Add tooltip for arch review & break up delete funct 🐛 UX improvements for app assessment/review discard Nov 8, 2023
@ibolton336 ibolton336 marked this pull request as ready for review November 8, 2023 19:58
@ibolton336 ibolton336 marked this pull request as draft November 8, 2023 19:59
Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 force-pushed the app-actions-discard-review-fix branch from 5c47660 to cf4cfee Compare November 8, 2023 20:10
@ibolton336 ibolton336 marked this pull request as ready for review November 8, 2023 20:10
@ibolton336 ibolton336 added the priority/release-blocker Must be staffed and worked in time for the next release. label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker Must be staffed and worked in time for the next release.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant