Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update manage imports table #1558

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Nov 20, 2023

Resolves https://issues.redhat.com/browse/MTA-1693
Resolves https://issues.redhat.com/browse/MTA-1716

  • Invalidates queries for import summaries when deleting to trigger a refetch
  • Refactors manage imports table to fix mta-1693 issue and use new table format
  • Updates template to reflect new fields available for owner / contributor

@ibolton336 ibolton336 force-pushed the mta-1693 branch 2 times, most recently from d69b466 to d69e399 Compare November 21, 2023 19:00
@ibolton336
Copy link
Member Author

konveyor/tackle2-hub#538

Signed-off-by: ibolton336 <ibolton@redhat.com>
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e9f95b) 39.41% compared to head (c951d77) 40.49%.

❗ Current head c951d77 differs from pull request most recent head 7ec982c. Consider uploading reports for the commit 7ec982c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
+ Coverage   39.41%   40.49%   +1.07%     
==========================================
  Files         146      145       -1     
  Lines        4775     4638     -137     
  Branches     1138     1087      -51     
==========================================
- Hits         1882     1878       -4     
+ Misses       2879     2746     -133     
  Partials       14       14              
Flag Coverage Δ
client 40.49% <ø> (+1.07%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with one suggestion on the error popover with the external href

Comment on lines +302 to +308
<a
href="https://tackle-docs.konveyor.io/documentation/doc-installing-and-using-tackle/master/index.html#importing-applications_tackle"
target="_blank"
rel="noreferrer"
>
{t("actions.checkDocumentation")}
</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use component client/src/app/components/ExternalLink.tsx here.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSV content-wise looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants