🐛 Refactor questionnaire template downloading #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://issues.redhat.com/browse/MTA-1720 Refactor the questionnaire template download to follow the direct download of the application / manage imports / download CSV template. Summary of changes: - Move template files to `client/public/templates` - Reconfigure webpack to copy the template folder to `dist/` - Update URLs for the new location - Convert the questionnaire template download to use an `<a download>` tag Button Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
=======================================
Coverage 39.55% 39.55%
=======================================
Files 146 146
Lines 4786 4786
Branches 1143 1143
=======================================
Hits 1893 1893
Misses 2879 2879
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tested in dev & prod mode. LGTM! |
ibolton336
approved these changes
Nov 28, 2023
This was referenced Dec 11, 2023
1 task
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-1720
Refactor the questionnaire template download to follow the direct download of the application / manage imports / download CSV template.
Summary of changes:
client/public/templates/dist/<a download>tag Button