🐛 Fix pagination effects - for client tables, use filteredItems instead of items length for totalItemCount
#1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of items length for totalItemCount -- maybe should rename that Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
sjd78
approved these changes
Dec 14, 2023
This was referenced Dec 16, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the same fix in the new react-table-batteries code as well. Note to self: Perhaps we should rename the
totalItemCounttofilteredItemCountin the new version, since it really should be the count of all items just before pagination (after filtering), not the total number of items in the unfiltered collection.For client-side tables, the
totalItemCountis derived internally insidegetLocalTableControlDerivedState, and it was incorrectly usingitems.length. Changing that tofilteredItems.lengthmakes the logic inusePaginationEffectsbehave as intended, which means if the user ends up on an invalid pagination page (e.g. they are on page 2 and they apply a filter that has results on one page), it will kick them back to the last valid page.cc @ibolton336