🐛 Do not show the code viewer when no code snippet available #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
approved these changes
Feb 14, 2024
sjd78
requested changes
Feb 14, 2024
...p/pages/issues/issue-detail-drawer/file-incidents-detail-modal/incident-code-snip-viewer.tsx
Outdated
Show resolved
Hide resolved
...p/pages/issues/issue-detail-drawer/file-incidents-detail-modal/incident-code-snip-viewer.tsx
Outdated
Show resolved
Hide resolved
ibolton336
force-pushed
the
empty-state-code-snippet
branch
from
bb1f1e5
to
3ece33d
Compare
Signed-off-by: Ian Bolton <ibolton@redhat.com>
ibolton336
force-pushed
the
empty-state-code-snippet
branch
from
3ece33d
to
1b7f28a
Compare
ibolton336
added
the
cherry-pick/release-0.3
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Resolves #1472 - Adds an empty state to the codeviewer when the codesnip is not populated / is an empty string or whitespace characters. <img width="1188" alt="Screenshot 2024-02-13 at 12 43 05 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/eed3cf5d-e5a4-44eb-846f-6397c50b23a9"> Signed-off-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
ibolton336
added a commit
that referenced
this pull request
Feb 26, 2024
…1699) Resolves #1472 - Adds an empty state to the codeviewer when the codesnip is not populated / is an empty string or whitespace characters. <img width="1188" alt="Screenshot 2024-02-13 at 12 43 05 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/eed3cf5d-e5a4-44eb-846f-6397c50b23a9"> Signed-off-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Ian Bolton <ibolton@redhat.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1472 - Adds an empty state to the codeviewer when the codesnip is not populated / is an empty string or whitespace characters.