Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix wave subtable pagination #1689

Merged
merged 1 commit into from
Feb 16, 2024
Merged

🐛 Fix wave subtable pagination #1689

merged 1 commit into from
Feb 16, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Feb 15, 2024 •
edited
Loading

@ibolton336
🐛 Fix wave subtable pagination
0674efd 
Signed-off-by: Ian Bolton <ibolton@redhat.com>
@JustinXHale
Copy link
Member

This looks great @ibolton336

sjd78
sjd78 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Changes:

  • Only show pagination when >9 items are to be displayed.
  • Use compact pagination when displayed to have a visual difference from the containing table's pagination controls.

@ibolton336 ibolton336 merged commit 9be2ac1 into konveyor:main Feb 16, 2024
7 checks passed
@ibolton336 ibolton336 deleted the mta-1790 branch February 26, 2024 18:53
This was referenced Apr 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibolton336 @JustinXHale @sjd78