Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Address style issues on assessment summary / questionnaire view #1706

Merged
merged 5 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@
"email": "Email",
"error": "Error",
"errorReport": "Error report",
"explanation": "Explanation",
"exclude": "Exclude",
"exportToIssue": "Export to Issue Manager",
"facts": "Facts",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ const QuestionnaireSummary: React.FC<QuestionnaireSummaryProps> = ({
isVertical
aria-label="Tabs for summaryData sections"
role="region"
className="tabs-vertical-container__tabs"
>
{[
<Tab
Expand Down
13 changes: 8 additions & 5 deletions client/src/app/components/questions-table/questions-table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,14 @@ const QuestionsTable: React.FC<{
className={spacing.pyLg}
>
<ExpandableRowContent>
{question.explanation}
<AnswerTable
hideAnswerKey={hideAnswerKey}
answers={question.answers}
/>
<div className={spacing.mlMd}>
<strong>{t("terms.explanation")}: &nbsp;</strong>
<span>{question.explanation}</span>
<AnswerTable
hideAnswerKey={hideAnswerKey}
answers={question.answers}
/>
</div>
</ExpandableRowContent>
</Td>
</Tr>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
.tabs-vertical-container {
display: flex;
margin-top: 1.5em;
}

.tabs-vertical-container__tabs {
margin-top: 1.5em;
}

.tabs-vertical-container .pf-v5-c-tabs {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from "react";
import { useParams } from "react-router-dom";
import "./assessment-summary-page.css";
import QuestionnaireSummary, {
SummaryType,
} from "@app/components/questionnaire-summary/questionnaire-summary";
Expand Down
Loading