Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove unnecessary query invalidations for reviews #1735

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Mar 4, 2024

https://issues.redhat.com/browse/MTA-2359

  • Removes query invalidation & additional archetypes / reviews api calls inside each instance of a rendered (but hidden) drawer. This was causing a huge performance hit.

  • Adds margin at top of reviews tab

Screenshot 2024-03-04 at 2 46 40 PM

Signed-off-by: Ian Bolton <ibolton@redhat.com>
@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Mar 4, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

Just thinking about it, I don't understand why a simple fetch of the applications or archetypes should result in the reviews being refetched. That's a bit of a strange flow. I wonder why it was that way in the first place.

@ibolton336 ibolton336 merged commit 6bbca51 into konveyor:main Mar 5, 2024
6 checks passed
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this pull request Mar 5, 2024
https://issues.redhat.com/browse/MTA-2359

- Removes query invalidation & additional archetypes / reviews api calls
inside each instance of a rendered (but hidden) drawer. This was causing
a huge performance hit.

 - Adds margin at top of reviews tab
<img width="540" alt="Screenshot 2024-03-04 at 2 46 40 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/9c6c8a8f-f8c6-45c9-8609-86a30e206a99">

Signed-off-by: Ian Bolton <ibolton@redhat.com>
ibolton336 added a commit that referenced this pull request Mar 5, 2024
https://issues.redhat.com/browse/MTA-2359

- Removes query invalidation & additional archetypes / reviews api calls
inside each instance of a rendered (but hidden) drawer. This was causing
a huge performance hit.

- Adds margin at top of reviews tab <img width="540" alt="Screenshot
2024-03-04 at 2 46 40 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/9c6c8a8f-f8c6-45c9-8609-86a30e206a99">

<!--
## PR Title Prefix

Every **PR Title** should be prefixed with :text: to indicate its type.

- Breaking change: ⚠️ (`⚠️`)
- Non-breaking feature: ✨ (`✨`)
- Patch fix: 🐛 (`🐛`)
- Docs: 📖 (`📖`)
- Infra/Tests/Other: 🌱 (`🌱`)
- No release note: 👻 (`👻`)

For example, a pull request containing breaking changes might look like
`⚠️ My pull request contains breaking changes`.

Since GitHub supports emoji aliases (ie. `👻`), there is no need to
include
the emoji directly in the PR title -- **please use the alias**. It used
to be
the case that projects using emojis for PR typing had to include the
emoji
directly because GitHub didn't render the alias. Given that `⚠️`
is
easy enough to read as text, easy to parse in release tooling, and
rendered in
GitHub well, we prefer to standardize on the alias.

For more information, please see the Konveyor
[Versioning
Doc](https://github.com/konveyor/release-tools/blob/main/VERSIONING.md).
-->

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants