Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Filter pre-existing selections from options #1760

Merged
merged 1 commit into from
Mar 20, 2024
Merged

🐛 Filter pre-existing selections from options #1760

merged 1 commit into from
Mar 20, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 requested a review from sjd78 March 11, 2024 21:19
@sjd78 sjd78 added this to the v0.3.1 milestone Mar 14, 2024
sjd78
sjd78 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
client/src/app/components/Autocomplete.tsx Outdated Show resolved Hide resolved
@ibolton336 ibolton336 force-pushed the mta-2400 branch 2 times, most recently from 1ca99ba to 3f84088 Compare March 20, 2024 14:54
@ibolton336
🐛 Filter pre-existing selections from options
0a6f572 
Signed-off-by: Ian Bolton <ibolton@redhat.com>

Signed-off-by: Ian Bolton <ibolton@redhat.com>
sjd78
sjd78 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new iteration is much more compact! LGTM

@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Mar 20, 2024
@ibolton336 ibolton336 merged commit f9daef3 into konveyor:main Mar 20, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@ibolton336 @web-flow
🐛 Filter pre-existing selections from options (#1760)
c731415 
Resolves https://issues.redhat.com/browse/MTA-2400

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
ibolton336 added a commit that referenced this pull request Mar 20, 2024
@konveyor-ci-bot @ibolton336
🐛 Filter pre-existing selections from options (#1760) (#1789)
abc6114 
Resolves https://issues.redhat.com/browse/MTA-2400

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
This was referenced May 8, 2024
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ibolton336 @sjd78