✨ Set application delete as danger kebab menu item (#1829) #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd78
force-pushed
the
backport_1829_release-0.3
branch
from
303d312 to
ab644f8
Compare
mguetta1
requested changes
Apr 11, 2024
Comment on lines
-1015
to
-1025
| { | ||
| isAriaDisabled: | ||
| application.migrationWave !== null, | ||
| tooltipProps: { | ||
| content: | ||
| application.migrationWave !== null | ||
| ? t( | ||
| "message.cannotDeleteApplicationsAssignedToMigrationWave" | ||
| ) | ||
| : "", | ||
| }, |
There was a problem hiding this comment.
Looks like #1803 should not be backported yet, fix version is MTA 7.1.0
https://issues.redhat.com/browse/MTA-2225
There was a problem hiding this comment.
The bot failed to create the backport/cherry-pick so I did it manually without thinking about it too much. I'll go double check the original PR and update. There was no intention to also include any other change.
There was a problem hiding this comment.
Removed this erroneous change in the latest push.
There was a problem hiding this comment.
Oh wait -- I see the nuance now. I'll keep the pre-1803 version of the delete button but move it to the newer location, and add the danger style
sjd78
force-pushed
the
backport_1829_release-0.3
branch
from
ab644f8 to
234de06
Compare
Part of konveyor#1318 Resolves: https://issues.redhat.com/browse/MTA-2261 --------- Signed-off-by: Maayan Hadasi <mguetta@redhat.com> Co-authored-by: Scott Dickerson <sdickers@redhat.com> Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
backport_1829_release-0.3
branch
from
234de06 to
a683f4b
Compare
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1318
Resolves: https://issues.redhat.com/browse/MTA-2261
Backport-of: #1829