Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Extract IconWithLabel component #1878

Merged
merged 3 commits into from
Apr 25, 2024
Merged

✨ Extract IconWithLabel component #1878

merged 3 commits into from
Apr 25, 2024

Conversation

rszwajko
Copy link
Collaborator

Resolves: #1873

@rszwajko
Copy link
Collaborator Author

Before

Screenshot from 2024-04-22 22-13-00

After

Screenshot from 2024-04-22 22-09-12

@rszwajko rszwajko marked this pull request as ready for review April 22, 2024 20:24
sjd78
sjd78 requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good other than the hasTrailingItem prop.

client/src/app/components/Icons/IconedStatus.tsx Outdated Show resolved Hide resolved
client/src/app/components/Icons/IconWithLabel.tsx Outdated Show resolved Hide resolved
@sjd78 sjd78 linked an issue Apr 23, 2024 that may be closed by this pull request
[UI] Tag spacing konveyor/enhancements#148
Closed
@rszwajko
Extract IconWithLabel component
ae15fad 
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko
Add topology icon to the presets
47ac533 
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko rszwajko requested a review from sjd78 April 24, 2024 19:00
@rszwajko
Copy link
Collaborator Author

@sjd78
trailingItemTooltipMessage is a separate prop to increase flexibility - currently we use the same tooltip for both icons.

sjd78
sjd78 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The topologyIcon preset prop looks nice.

@sjd78 sjd78 added this to the v0.4.0 milestone Apr 25, 2024
@rszwajko rszwajko merged commit 312b8b8 into konveyor:main Apr 25, 2024
7 checks passed
ibolton336 pushed a commit to ibolton336/tackle2-ui that referenced this pull request Apr 25, 2024
@rszwajko @ibolton336
✨ Extract IconWithLabel component (konveyor#1878)
b348109 
Resolves: konveyor#1873

---------

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
This was referenced May 8, 2024
Merged
Merged
@sjd78 sjd78 mentioned this pull request May 9, 2024
Closed
This was referenced Jun 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

@ibolton336 ibolton336 Awaiting requested review from ibolton336 ibolton336 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve tag spacing [UI] Tag spacing
2 participants
@rszwajko @sjd78