-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Remove extra link from empty task drawer #2073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the task drawer's empty state, remove the "View all tasks" link from the empty state. The link is already available in the task drawer header. Resolves: https://issues.redhat.com/browse/MTA-3220 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
task_drawer_extra_link
branch
from
August 30, 2024 22:30
18f1b9a
to
62b4022
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
+ Coverage 39.20% 42.53% +3.33%
==========================================
Files 146 171 +25
Lines 4857 5504 +647
Branches 1164 1305 +141
==========================================
+ Hits 1904 2341 +437
- Misses 2939 3147 +208
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
approved these changes
Sep 3, 2024
sjd78
added
the
cherry-pick/release-0.5
This PR should be cherry-picked to release-0.5 branch.
label
Sep 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
On the task drawer's empty state, remove the "View all tasks" link from the empty state. The link is already available in the task drawer header. Resolves: https://issues.redhat.com/browse/MTA-3220 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
sjd78
pushed a commit
that referenced
this pull request
Sep 4, 2024
On the task drawer's empty state, remove the "View all tasks" link from the empty state. The link is already available in the task drawer header. Resolves: https://issues.redhat.com/browse/MTA-3220 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
This was referenced Oct 1, 2024
This was referenced Jan 10, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the task drawer's empty state, remove the "View all tasks" link from the empty state. The link is already available in the task drawer header.
Resolves: https://issues.redhat.com/browse/MTA-3220