Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Image build, use variables for repo push #2090

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Sep 12, 2024

To help out people building images in a fork, use github action variables to be able to configure the target registry and image names.

Now on a fork, the destination of an image build can be set by using action variables1:

  • IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  • IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and action secrets2:

  • QUAY_PUBLISH_ROBOT
  • QUAY_PUBLISH_TOKEN

Footnotes

  1. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository

  2. https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret

To help out people building images in a fork,
use github action variables to be able to configure
the target registry and image names.

Now on a fork, the destination of an image build can be set
by using Action Variables:
  - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and secrets:
  - QUAY_PUBLISH_ROBOT
  - QUAY_PUBLISH_TOKEN

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.15%. Comparing base (b654645) to head (16cf810).
Report is 232 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
+ Coverage   39.20%   42.15%   +2.95%     
==========================================
  Files         146      174      +28     
  Lines        4857     5577     +720     
  Branches     1164     1391     +227     
==========================================
+ Hits         1904     2351     +447     
- Misses       2939     3105     +166     
- Partials       14      121     +107     
Flag Coverage Δ
client 42.15% <ø> (+2.95%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd78 sjd78 merged commit 14918d5 into konveyor:main Sep 12, 2024
12 checks passed
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
To help out people building images in a fork, use github action
variables to be able to configure the target registry and image names.

Now on a fork, the destination of an image build can be set by using
action variables[^1]:
  - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and action secrets[^2]:
  - QUAY_PUBLISH_ROBOT
  - QUAY_PUBLISH_TOKEN

[^1]:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository
[^2]:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
To help out people building images in a fork, use github action
variables to be able to configure the target registry and image names.

Now on a fork, the destination of an image build can be set by using
action variables[^1]:
  - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and action secrets[^2]:
  - QUAY_PUBLISH_ROBOT
  - QUAY_PUBLISH_TOKEN

[^1]:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository
[^2]:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Sep 19, 2024
To help out people building images in a fork, use github action
variables to be able to configure the target registry and image names.

Now on a fork, the destination of an image build can be set by using
action variables[^1]:
  - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and action secrets[^2]:
  - QUAY_PUBLISH_ROBOT
  - QUAY_PUBLISH_TOKEN

[^1]:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository
[^2]:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Oct 28, 2024
To help out people building images in a fork, use github action
variables to be able to configure the target registry and image names.

Now on a fork, the destination of an image build can be set by using
action variables[^1]:
  - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and action secrets[^2]:
  - QUAY_PUBLISH_ROBOT
  - QUAY_PUBLISH_TOKEN

[^1]:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository
[^2]:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants