Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ActionsColumn to Job Functions table #2101

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

DvoraShechter1
Copy link
Contributor

@DvoraShechter1 DvoraShechter1 commented Sep 19, 2024

Update the Actions column in the Job Functions table to use PatternFly 5 controls, replacing the PatternFly 4 controls.
Relates to #1318

Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (b654645) to head (0fd7e0a).
Report is 243 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   39.20%   41.98%   +2.78%     
==========================================
  Files         146      175      +29     
  Lines        4857     5630     +773     
  Branches     1164     1395     +231     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3145     +206     
- Partials       14      121     +107     
Flag Coverage Δ
client 41.98% <ø> (+2.78%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
@mguetta1 mguetta1 changed the title ✨ add ActionsColumn to Job Functions table ✨ [WIP] Add ActionsColumn to Job Functions table Sep 23, 2024
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Some minor comments:

  1. mixing links and text in the issue description (first post in the Conversation view) is problematic - in our process the message will be used as the git commit message (which is plain text). A good solution is to list links below the description i.e. see 🌱 Update project to use nodejs 20, npm >=10.5.2 (#2062) #2064 or ✨ Use InfiniteScroller pattern for the Task Drawer #2049
  2. note that part of your description (like in the [Stakeholder](https://127.0.0.1/controls/stakeholders) table ) is not accurate - currently (with PR ✨ Update stakeholder groups table to use ActionsColumn #2095 and ✨ Update stakeholders table to use ActionsColumn #1923) we have both stakeholders tables fixed.
  3. you can use [WIP] prefix as a way to indicate work-in-progress but GitHub has nice draft PR functionality (check "convert to draft" link below reviewers list)
    Screenshot from 2024-09-26 18-56-12

@mguetta1 mguetta1 marked this pull request as draft September 26, 2024 19:07
@mguetta1 mguetta1 changed the title ✨ [WIP] Add ActionsColumn to Job Functions table ✨ Add ActionsColumn to Job Functions table Sep 26, 2024
@DvoraShechter1 DvoraShechter1 marked this pull request as ready for review September 29, 2024 11:24
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjd78 sjd78 dismissed mguetta1’s stale review October 30, 2024 16:32

Concerns were addressed.

Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants