Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to translate annotation-literals #129

Closed
jmle opened this issue Jul 19, 2024 · 2 comments
Closed

Ability to translate annotation-literals #129

jmle opened this issue Jul 19, 2024 · 2 comments
Assignees
@abrugaro
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jmle
Copy link
Contributor

jmle commented Jul 19, 2024

We now have the ability to match on annotated fields, methods and classes. We must add the ability to translate windup rules with these constructs.
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 19, 2024
@jmle jmle mentioned this issue Jul 19, 2024
Open
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jul 19, 2024
@jmle jmle assigned jmle and abrugaro and unassigned jmle Aug 27, 2024
@abrugaro abrugaro mentioned this issue Sep 24, 2024
Merged
aufi pushed a commit that referenced this issue Oct 10, 2024
@abrugaro
✨ Add the ability to translate annotation literals (#132)
e6fb4d7 
Solves #129

This PR also:
* Adds an e2e test to cover the translation of a whole rule
* Replaces imports from `github.com/fabianvf/windup-rulesets-yaml` to
`github.com/konveyor/windup-shim` as the first repo no longer exists.

---------

Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
@jmle
Copy link
Contributor Author

jmle commented Oct 30, 2024

Fixed by #132

@jmle jmle closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Planning Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrugaro abrugaro

Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmle @abrugaro