Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert windup XML tests into YAML format #119

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented Apr 3, 2024

This is doing two things:

  1. This removes the report package that we no longer require and is not used anywhere. This is the commit ff28cf5

  2. Conversion of XML tests into YAML tests 2eacea6

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad marked this pull request as draft April 3, 2024 19:13
@pranavgaikwad pranavgaikwad force-pushed the testRunner branch 2 times, most recently from 0df8cfd to ca087e3 Compare April 8, 2024 21:26
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Copy link

github-actions bot commented Apr 8, 2024

Overall success rate: 80.37% (1900/2364)

@pranavgaikwad pranavgaikwad marked this pull request as ready for review April 18, 2024 14:57
Copy link
Collaborator

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense; nothing looks wrong.

I would consider this a VISACK because I am not up to speed on all the intricacies of the testing that Windup contained.

@pranavgaikwad pranavgaikwad merged commit 8f5c5b7 into konveyor:main Apr 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants