Skip to content

Conversation

artembelik
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 12:36
@artembelik artembelik self-assigned this Sep 26, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates API documentation for the tag list component by adding proper JSDoc annotations and improving type safety.

  • Replaces string literal type with KbqOrientation enum for the orientation property
  • Adds comprehensive @docs-private annotations to internal methods and properties
  • Removes undocumented markers from the public API guard file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
tools/public_api_guard/components/tags.api.md Updates API documentation to reflect type changes and remove undocumented markers
packages/components/tags/tag-list.component.ts Adds JSDoc annotations and replaces string literal orientation type with KbqOrientation enum

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Visit the preview URL for this PR (updated for commit ee3151d):

https://koobiq-next--prs-1035-vhfaetva.web.app

(expires Wed, 01 Oct 2025 12:42:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

/**
* Implemented as part of ControlValueAccessor.
*
* @docs-private
Copy link
Contributor

@NikGurev NikGurev Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно не помечать т.к. оно итак фильтруется, аналогично для остальных

OnDestroy,
CanUpdateErrorState
{
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а почему не в одну строку ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants