Change landingPage and identifier to us the canonical url for a given item #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… item For example: Hub Pages will be routed to /pages/id_or_slug, documents will be routed to /documents/id_or_slug, datasets will be routed to /datasets/id_or_slug, etc. Previously, all items were routes to /datasets/id_or_slug, resulting in invalid urls
| @@ -45,7 +45,7 @@ export = class OutputDcatUs11 { | |||
| dcatConfig = _.get(siteModel, 'data.feeds.dcatUS11'); | |||
| } | |||
|
|
|||
| const { stream: dcatStream, dependencies } = getDataStreamDcatUs11(hostname, dcatConfig); | |||
There was a problem hiding this comment.
I believe this still could break the changes I made to use the hostname when the custom domain and the site item's url do not match, just as a heads up.
There was a problem hiding this comment.
@drspacemanphd thanks for catching that! I made changes accordingly.
…nd identifier urls
drspacemanphd
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://devtopia.esri.com/dc/hub/issues/2571
Previously, all items were routed to
/datasets/:id, resulting in invalid urls.Examples of new urls:
/pages/:id_or_slug/documents/:id_or_slug/datasets/:id_or_slug