F/1915 reflect custom config updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting the dcat-us 1.1 data stream
sonofflynn89
commented
Sep 15, 2021
src/dcat-us/index.test.ts
Outdated
| expect(chk1.distribution.length).toBe(6); | ||
| }); | ||
|
|
||
| it('formats catalog correctly', async function () { |
There was a problem hiding this comment.
Well, that's not supposed to be there 😅
There was a problem hiding this comment.
I thought I had only copied one test, but it looks like the it('formats catalog correctly') test got duplicated on accident @andrewctate
drewdaemon
suggested changes
Sep 15, 2021
|
Thanks for the reminder @andrewctate! I was about to do it before we got into the whole structural discussion with Thomas, but I forgot 😅. |
sonofflynn89
commented
Sep 27, 2021
example-app/config/default.json
Outdated
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "port": "8080", | |||
| "arcgisPortal": "https://www.arcgis.com" | |||
| "arcgisPortal": "https://www.mapsqa.arcgis.com" | |||
There was a problem hiding this comment.
Reminder to myself to remove this
drewdaemon
added a commit
that referenced
this pull request
Sep 28, 2021
creating release v1.1.0 for koopjs/koop-output-dcat-us-11 name: v1.1.0 tag_name: v1.1.0 target_commitish: 1980b21 endpoint: https://api.github.com body: Added - Supports custom configuration values found at `site.data.feeds.dcatUS11` [#4](#4) ? publish release to github? (y/N) �[35D�[35C package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for a site's custom configurations.
Affects the following issues:
https://devtopia.esri.com/dc/hub/issues/1915
https://devtopia.esri.com/dc/hub/issues/2064