Move progress bar widget out of kartapi and into dockwidget #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the UI concerns in the GUI component and removes the UI dependancy in kartapi. An output_handler hook is added to Repository.clone to enable progress reporting.
hamishcampbell
force-pushed
the
move-clone-progressbar
branch
from
275a53b to
781e4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository.clonehas a UI dependancy – it attempts to create a progress bar for reporting the progress of the clone operation. There are no other UI dependancies inkartapiand this prevents the re-use of the code in other non-GUI components.This change moves the progress bar into the calling
KartDockWidgetGUI component. Anoutput_handlerarg is provided inRepository.cloneso the caller can attached it's own handler. The existing progress bar code is copied over.