Migrate to v2 Docker Compose & Update QGIS/Kart Versions #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishcampbell
force-pushed
the
upgrade-docker-compose
branch
from
e7f1bb8 to
f656023
Compare
hamishcampbell
force-pushed
the
upgrade-docker-compose
branch
from
97cab8a to
9f25da4
Compare
hamishcampbell
changed the title
craigds
changed the title
craigds
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing due to GitHub deprecating docker compose v1. This makes minor adjustments to support v2 as well as updating our Kart and QGIS targets.
Note that latest QGIS docker images have externally managed python installations, however for the purposes of testing we're happy to set
PIP_BREAK_SYSTEM_PACKAGES=1. We don't actually require any additional dependancies in the plugin. If we need them in future we should consider the steps in https://github.com/qgis/QGIS/tree/master/.docker#running-tests-for-a-python-plugin which include installing the plugin into QGIS.