Skip to content

Commit

Permalink
Require python3.9 to workaround some issues...
Browse files Browse the repository at this point in the history
... with python3.7 on windows - specifically:
- pysqlite wheel doesn't build without patching at <3.8
- abi info on windows gets better at 3.9
  • Loading branch information
olsen232 committed Nov 11, 2022
1 parent 8d436df commit e08fba8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
env:
CCACHE_DIR: ${{ github.workspace }}/.cache/ccache
CCACHE_COMPRESS: "1"
PY_VER: "3.7"
PY_VER: "3.9"
KART_POSTGRES_URL: "postgresql://postgres:@localhost:5432/postgres"
KART_SQLSERVER_URL: "mssql://sa:PassWord1@localhost:1433/master"
KART_MYSQL_URL: "mysql://root:PassWord1@localhost:3306"
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:
name: Windows
runs-on: windows-2019
env:
PY_VER: "3.7"
PY_VER: "3.9"
FORCE_COLOR: "YES"

# We want to run on external PRs, but not on our own internal PRs as they'll be run
Expand Down Expand Up @@ -507,7 +507,7 @@ jobs:
env:
CCACHE_DIR: ${{ github.workspace }}/.cache/ccache
CCACHE_COMPRESS: "1"
PY_VER: "3.7"
PY_VER: "3.9"
HOMEBREW_CACHE: ${{ github.workspace }}/.cache/brew
HOMEBREW_NO_INSTALL_CLEANUP: "1"
FORCE_COLOR: "YES"
Expand Down Expand Up @@ -778,7 +778,7 @@ jobs:
env:
CCACHE_DIR: ${{ github.workspace }}/.cache/ccache
CCACHE_COMPRESS: "1"
PY_VER: "3.7"
PY_VER: "3.9"
KART_POSTGRES_URL: "postgresql://postgres:@localhost:5432/postgres"
KART_SQLSERVER_URL: "mssql://sa:PassWord1@localhost:1433/master"
KART_MYSQL_URL: "mysql://root:PassWord1@localhost:3306"
Expand Down Expand Up @@ -1032,7 +1032,7 @@ jobs:
runs-on: windows-2019
continue-on-error: true
env:
PY_VER: "3.7" # needs to match the Windows job since we use its vendor archive.
PY_VER: "3.9" # needs to match the Windows job since we use its vendor archive.
FORCE_COLOR: "YES"

# We want to run on external PRs, but not on our own internal PRs as they'll be run
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ endif()

# OSX: prefer Homebrew over Frameworks
set(Python3_FIND_IMPLEMENTATIONS "CPython")
find_package(Python3 3.7 REQUIRED COMPONENTS Development Interpreter)
find_package(Python3 3.9 REQUIRED COMPONENTS Development Interpreter)
pythongetabiinfo()

if(USE_VCPKG)
Expand Down
2 changes: 1 addition & 1 deletion vcpkg-vendor/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ set(EXE_LIST "")
#
# Need Development here or VcPkg falls back to the system interpreter
find_package(
Python3 3.7
Python3 3.9
COMPONENTS Development Interpreter
REQUIRED)
cmake_path(GET Python3_STDLIB FILENAME Python3_STDLIB_DIR_NAME)
Expand Down

0 comments on commit e08fba8

Please sign in to comment.