Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches which create or delete datasets are not yet supported #239

Closed
olsen232 opened this issue Sep 2, 2020 · 1 comment · Fixed by #246
Closed

Patches which create or delete datasets are not yet supported #239

olsen232 opened this issue Sep 2, 2020 · 1 comment · Fixed by #246

Comments

@olsen232
Copy link
Collaborator

olsen232 commented Sep 2, 2020 •
edited by rcoup
Loading

Some assumptions have not been changed since V1:

  1. every patch is assumed to apply to an existing dataset

  2. every working copy change is assumed to apply to an existing dataset - ie, we do not handle the user creating tables or deleting tables in the working copy

  3. as a result, the only way to create a dataset is using the sno import command, just as in datasets V1.

  4. and there is no way to delete datasets at all.
This was referenced Sep 7, 2020
Merged
Merged
@rcoup
Copy link
Member

rcoup commented Sep 9, 2020

Should (2) & (4) become new issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support patches that create or delete datasets koordinates/kart
2 participants
@rcoup @olsen232