Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support patches that create or delete datasets #246

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Support patches that create or delete datasets #246

merged 2 commits into from
Sep 8, 2020

Conversation

olsen232
Copy link
Collaborator

@olsen232 olsen232 commented Sep 8, 2020

Related links:

Fixes #239

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

@olsen232 olsen232 requested a review from craigds September 8, 2020 23:00
craigds
craigds approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@craigds craigds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olsen232 olsen232 merged commit 4ac3472 into master Sep 8, 2020
@olsen232 olsen232 deleted the dataset_patches branch September 8, 2020 23:38
rcoup
rcoup reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@rcoup rcoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some minor doc/style comments

sno/dataset2.py Show resolved Hide resolved
sno/git_util.py Show resolved Hide resolved
sno/git_util.py Show resolved Hide resolved
sno/rich_tree_builder.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcoup rcoup rcoup left review comments

@craigds craigds craigds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patches which create or delete datasets are not yet supported
3 participants
@olsen232 @craigds @rcoup