Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to get the history of a given feature #496

Closed
volaya opened this issue Nov 2, 2021 · 2 comments
Closed

Add functionality to get the history of a given feature #496

volaya opened this issue Nov 2, 2021 · 2 comments
Assignees

Comments

@volaya
Copy link

volaya commented Nov 2, 2021

Just like now you can get a list of commits that affect a given layer, it should be possible to get the list of commits that affect a feature, given its id

@craigds
Copy link
Member

craigds commented Nov 4, 2021

at the moment this can be done by finding out the internal path of the feature (somehow!) and doing:

kart log HEAD -- datasetname/.table-dataset/feature/A/A/A/R/kc0EQA==

... however that's not a real solution. But i would like it to continue working, if possible, as it's a pretty handy feature for developers I think.

A better solution might be kart log HEAD -- datasetname:<primarykey>.

Since normal paths above shouldn't ever contain colons (related: #497) the parsing is unambiguous here.

craigds added a commit that referenced this issue Nov 18, 2021
In #498 I added some code to
pre-parse arguments that we're going to pass to `git log`, to figure out
which of the arguments were paths.

This was necessary for future work
(#496). Unfortunately I failed
to account for git's options that take an argument, notably `-n 1`, and
the `1` got treated as a path.

This change fixes the bug for:
* `-n / --max-limit`
* `--after / --since / --until / --before`
* `--skip`

And incidentally adds those options to the `--help` output.
craigds added a commit that referenced this issue Nov 19, 2021
In #498 I added some code to
pre-parse arguments that we're going to pass to `git log`, to figure out
which of the arguments were paths.

This was necessary for future work
(#496). Unfortunately I failed
to account for git's options that take an argument, notably `-n 1`, and
the `1` got treated as a path.

This change fixes the bug for:
* `-n / --max-limit`
* `--after` / `--since` / `--until` / `--before`
* `--skip`
* `--author` / `--committer`
* `--grep`

And incidentally adds those options to the `--help` output.
@craigds
Copy link
Member

craigds commented Dec 23, 2021

This was fixed in #513 and will be in the 0.10.8 release.

@craigds craigds closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants