Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to diff command to get the meta changes in all layers #514

Closed
volaya opened this issue Nov 30, 2021 · 1 comment
Closed

Add option to diff command to get the meta changes in all layers #514

volaya opened this issue Nov 30, 2021 · 1 comment

Comments

@volaya
Copy link

volaya commented Nov 30, 2021

Now the meta changes for a given layer can be obtained using

kart diff refa...refb datasetname:meta -ojson

But there is no way of showing exisiting meta changes for all layers modified between the selected commits.

A bit of context for this: In the plugin, we are trying to detect whether there are meta changes or no before opening elements such as the diff viewer, which for now assume that the schema doesnt change

@craigds
Copy link
Member

craigds commented Dec 20, 2021

Obvious way to implement this would be:

kart diff refa...refb *:meta -ojson

Since we forbid the * character in dataset names, this results in unambiguous syntax.

The only obvious problem is that * will be expanded by shells to a filename, if a file matching that pattern exists in the current directory. That seems pretty unlikely though and it can always be quoted, so probably not a big deal.

  • If we do this we should make it work for *:feature too
  • Also *:<featureID> - this seems easy enough to make work, and means for a single-layer repo, the user doesn't have to use the actual dataset name, which they may not remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants