Validate features - enforce types, keep ints in range #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsen232
force-pushed
the
validate_features
branch
from
b745463 to
ce7d14e
Compare
olsen232
force-pushed
the
validate_features
branch
from
ce7d14e to
1746d33
Compare
olsen232
changed the title
|
This change does also enforce types themselves (eg str vs int) but I was unaware of how important this was - have updated the documentation and the tests now |
olsen232
force-pushed
the
validate_features
branch
from
1746d33 to
4fc1e28
Compare
olsen232
force-pushed
the
validate_features
branch
from
4fc1e28 to
c7d01b8
Compare
|
@olsen232 any performance impact from this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we don't validate data on commit. Since GPKG doesn't care how many bits an integer has, committing a GPKG working copy can result in the dataset containing integers with too many bits - this would stop you from checking out a postgis working copy.
#293
Checklist: