Fix crashing during diff with 3d geometries #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoup
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Great!
Wider question: I wonder if it's worth having Z,M,ZM test datasets just to flush out some of this stuff? Though would need to be an E2E test we can parameterise that works through the core operations (diff/restore/commit/checkout/merge/conflicts/resolve/etc) with different datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
diffwas crashing when run against a working copy when the diffed geometries contained Z or M components. This fixes the issue and includes a test which runs against a tiny XYZ point dataset.Related links:
Fixes #483
Checklist: