Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cert verify issues via https clone on Linux #541

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Conversation

craigds
Copy link
Member

@craigds craigds commented Jan 12, 2022

Description

On a fresh Ubuntu install (tested with 21.04) kart clone wasn't using the certificate bundle included with it, and thus produced this error when cloning things:

root@a0cd8d48a21e:/downloads# kart clone https://github.com/Georepublic/kart-repo.git
Cloning into '/downloads/kart-repo.git/.clone'...
fatal: unable to access 'https://github.com/Georepublic/kart-repo.git/': error setting certificate verify locations:
  CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none

Todo

  • Actually test the deb build on ubuntu to make sure the issue goes away
  • figure out why this isn't happening in the e2e test in github actions?

Related links:

fixes #533

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

@craigds craigds requested a review from rcoup January 12, 2022 23:00
@craigds
Copy link
Member Author

craigds commented Jan 12, 2022

I tested this and the built deb works fine in Ubuntu 21.04 now 👍

@rcoup
Copy link
Member

rcoup commented Jan 13, 2022

Can we add a test for it into test/scripts/e2e-1.sh? Something basic like kart git ls-remote https://github.com/git/git.git HEAD. Need to check it fails first though 😃

@craigds
Copy link
Member Author

craigds commented Jan 13, 2022

I added the E2E test, and also cherry-picked it to master, and it failed on master but passed on this branch 👍

@craigds craigds merged commit a1535fc into master Jan 14, 2022
@craigds craigds deleted the fix-ca-certs-linux branch January 14, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison "git/kart clone"
2 participants