Fix for reflink - build reflink for macos11 #877
Conversation
On macOS, typically we use a Python.org distribution which has been built with compatibility back to OSX10.9 (via MACOSX_DEPLOYMENT_TARGET). reflink doesn't build on releases older than 10.12. Build reflink in vcpkg-vendor like the other python wheels, which forces/overrides the deployment target version.
| fienode = shutil.which("fienode") | ||
| has_checker = bool(clone_checker or fienode) | ||
|
|
||
| def _check_tile_is_reflinked(tile_path, repo, do_raise_skip=False): |
There was a problem hiding this comment.
wrt do_raise_skip, why wouldn't we always skip if the OS/infra doesn't support the test/feature? That's the pattern we've used elsewhere IIUC
There was a problem hiding this comment.
I added a couple new tests, both called test_working_copy_reflink.
If reflink is missing, we skip them.
However, I also used this same fixture to add some more reflink asserts to some existing import tests. Those tests should now make extra asserts - if they are able to do so - but shouldn't skip the test if they can't.
|
|
||
| def test_working_copy_reflink(cli_runner, data_archive, check_tile_is_reflinked): | ||
| if is_windows: | ||
| # Nothing to test, so let's mark test will show as "passed". |
There was a problem hiding this comment.
Yeah I was unsure what to do here: wasn't sure if I should try to use pytest.skip to mean "functionality is untested" and just a pass to mean "nothing to test". But I think you're right, pytest.skip makes more sense here.
Description
Building for macos10.9 (as we were doing previously) or equivalently pip installing it with the macos python version we have, ends up with a stub version of reflink that can't actually reflink anything.
Fixes a test that was failing due to reflink being less powerful than shutil.copy (it can't overwrite existing files, so we have to make sure the old files are out of the way).
Adds tests that actually check if things are reflinked.
#876