Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for basic s3 url redirects #952

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

olsen232
Copy link
Collaborator

@olsen232 olsen232 commented Dec 3, 2023

Adding url redirect rules to the linked-storage.json meta item causes those redirect rules to be honoured when fetching tiles for any commit that includes the new linked-storage.json.

However, this won't help when fetching tiles for older commits which were created before the redirect rules were added. The fix will be to add logic such that Kart finds redirect rules from a newer commit even when fetching tiles when checking out an older commit.

TODO in later PRs:
TODO: add logic such that Kart finds redirect rules from newer commits.
TODO: add a command for setting up redirect rules - right now there is just kart meta set which is pretty bare bones.

Related links:

#905

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

Adding url redirect rules to the linked-storage.json meta item
causes those redirect rules to be honoured when fetching tiles
for any commit that includes the new linked-storage.json.

However, this won't help when fetching tiles for older commits which
were created before the redirect rules were added.
The fix will be to add logic such that Kart finds redirect rules from
a newer commit even when fetching tiles when checking out an older commit.

TODO: add logic such that Kart finds redirect rules from newer commits.
TODO: add a command for setting up redirect rules - right now there is
just `kart meta set` which is pretty bare bones.
@olsen232 olsen232 requested a review from craigds December 3, 2023 23:08
@olsen232 olsen232 marked this pull request as draft December 4, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant