Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher filter and tab behaviour is incorrect #229

Closed
brentneave opened this issue May 21, 2023 · 1 comment · Fixed by #261
Closed

Publisher filter and tab behaviour is incorrect #229

brentneave opened this issue May 21, 2023 · 1 comment · Fixed by #261
Assignees
Labels
bug Something isn't working

Comments

@brentneave
Copy link

Describe the bug
Publisher filter and tab behaviour is incorrect

To Reproduce
Steps to reproduce the behavior:

  • Type “Blair” into the publisher filter
  • Blair Rogers will show up at the top of the “All” tab
  • Try and narrow your results down to users only by clicking the “Users” tab
  • A first click of the “Users” tab resets the filter keyword but does not select the “Users” tab
  • A second click of the “Users” tab selects the tab, displays all users instead of the results of the filter, since the filter keyword has been reset

Expected behavior

  • The user tab is selected after a single click
  • The keyword filter is not reset when changing tabs
  • The filter is preserved and only “Blair Rogers” (and any other matches) are visible under the “Users” tab

Screenshots
image

Version info (this is important!):

  • Operating System (e.g. Windows 10, macOS): MacOS
  • QGIS, Kart & Plugin details:
Kart Plugin version
1.0.11
QGIS version
3.30.0-'s-Hertogenbosch
Operating system
macOS 13.3.1 x86_64 i386 64bit
Kart version
Kart v0.12.2, Copyright (c) Kart Contributors
» GDAL v3.6.2; PROJ v9.1.1; PDAL v2.4.3
» PyGit2 v1.9.0; Libgit2 v1.4.2; Git v2.38.1; Git LFS v3.3.0
» SQLAlchemy v1.4.45; pysqlite3 v2.6.0/v3.40.0; SpatiaLite v5.0.1; Libpq v14.0.4

@brentneave brentneave added the bug Something isn't working label May 21, 2023
@nyalldawson
Copy link
Collaborator

Don't clear filter on changing tabs
Don't automatically change tabs when entering filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants