-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Explore-sections (Popular & Recent) #291
Comments
@BallJonathan |
@nyalldawson This >> just dynamically hiding popular or recent if these sections aren't present in explore-sections |
Yes we are dynamically hiding sections if they aren't present
Note that in future, we may add more sections (atm we just have two). A
full list of these sections is available on the /explore-sections/ endpoint.
The idea is we can add or remove a section from this endpoint, and then it
will / won't render in the plugin
Order should be
Popular
Browse
Publishers
Recent
(Any other sections)
That sound right, Jonathan?
…On Fri, 29 Sept 2023, 8:58 am BallJonathan, ***@***.***> wrote:
@nyalldawson <https://github.com/nyalldawson> This >> just dynamically
hiding popular or recent if these sections aren't present in
explore-sections
—
Reply to this email directly, view it on GitHub
<#291 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY4SMHKQYPHDWWJIVD4RWLLX4XJG5ANCNFSM6AAAAAA45MJGOE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Yep. Thanks for the better explanation!! Much appreciated. |
@nyalldawson Just checking you saw the msgs above. |
Yep, working on it! (This isn't actually a trivial change, there's a bit involved here) |
@nyalldawson " @nyalldawson had a look at the QGIS code for how its calling the explore API and saw this. Haven't tested but looks like we are only keeping panels if they contain at least one raster or vector. Any reason for this? There is also layer.rat and layer.grid layer types Clients indicate the type of panels they want to get back from the api with the item_type GET parameter |
At present Popular and recent tabs are hardcoded into the plugin.
Please change tab presence and content as described below:
API clients need to treat the
explore-sections
dynamicallyexplore-sections
endpoint, get list of possible sections1 and 2 are on this endpoint
koordinates.com/services/api/v1.x/explore-sections/
3 and 4 are on corresponding section endpoints
https://koordinates.com/services/api/v1.x/explore-sections/recent/
https://koordinates.com/services/api/v1.x/explore-sections/popular/
ATM we only have popular and recent sections, but we have designed it this way so we can add new sections in future (or remove them).
The text was updated successfully, but these errors were encountered: