Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Explore-sections (Popular & Recent) #291

Closed
BallJonathan opened this issue Sep 18, 2023 · 7 comments · Fixed by #293
Closed

Update Explore-sections (Popular & Recent) #291

BallJonathan opened this issue Sep 18, 2023 · 7 comments · Fixed by #293
Assignees
Labels
enhancement New feature or request question

Comments

@BallJonathan
Copy link

At present Popular and recent tabs are hardcoded into the plugin.

Please change tab presence and content as described below:

API clients need to treat the explore-sections dynamically

  1. Go to explore-sections endpoint, get list of possible sections
  2. Visit each of those sections and render their contents (1, 2, then 3, 4)
image

1 and 2 are on this endpoint
koordinates.com/services/api/v1.x/explore-sections/
3 and 4 are on corresponding section endpoints
https://koordinates.com/services/api/v1.x/explore-sections/recent/
https://koordinates.com/services/api/v1.x/explore-sections/popular/

ATM we only have popular and recent sections, but we have designed it this way so we can add new sections in future (or remove them).

@BallJonathan BallJonathan added the enhancement New feature or request label Sep 18, 2023
@nyalldawson
Copy link
Collaborator

@BallJonathan
I'm a little confused. Are we moving tabs around to match the order of the explore-sections results? Or will it always still be "popular -> browse > publishers > recent", and just dynamically hiding popular or recent if these sections aren't present in explore-sections?

@BallJonathan
Copy link
Author

@nyalldawson This >> just dynamically hiding popular or recent if these sections aren't present in explore-sections

@benpearman
Copy link

benpearman commented Sep 28, 2023 via email

@BallJonathan
Copy link
Author

Yep. Thanks for the better explanation!! Much appreciated.

@BallJonathan
Copy link
Author

@nyalldawson Just checking you saw the msgs above.

@nyalldawson
Copy link
Collaborator

Yep, working on it! (This isn't actually a trivial change, there's a bit involved here)

@BallJonathan
Copy link
Author

BallJonathan commented Oct 24, 2023

@nyalldawson
@benpearman asked this question awhile ago in slack. Posting here so you see it.

" @nyalldawson had a look at the QGIS code for how its calling the explore API and saw this. Haven't tested but looks like we are only keeping panels if they contain at least one raster or vector. Any reason for this? There is also layer.rat and layer.grid layer types
results_panel.py

Clients indicate the type of panels they want to get back from the api with the item_type GET parameter
Shouldn't need to do any filtering of panels in the response"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants