Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backend api to retrieve country listings #303

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Use backend api to retrieve country listings #303

merged 6 commits into from
Dec 1, 2023

Conversation

nyalldawson
Copy link
Collaborator

No description provided.

@nyalldawson
Copy link
Collaborator Author

@BallJonathan for testing -- should be no user-visible changes here!

@BallJonathan
Copy link

@nyalldawson

A few things to fix here.

  1. Sort is not required in Popular or Recent. They can be removed. Noting.... they only appear on these tabs after restarting QGIS, and once you switch between tabs, they vanish
  2. Can we give the Sort button a bit of padding? It's currently touching the Filter box.
Screen.Recording.2023-12-01.at.8.32.36.AM.mov

@nyalldawson
Copy link
Collaborator Author

@BallJonathan can you retest now please?

@BallJonathan
Copy link

BallJonathan commented Nov 30, 2023 •
edited
Loading

@nyalldawson Yep. Spot on. All done

@nyalldawson nyalldawson merged commit f4c2170 into master Dec 1, 2023
11 checks passed
@nyalldawson nyalldawson deleted the country_sort branch December 1, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyalldawson @BallJonathan