Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov configuration #131

Merged

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

enable coverage diff check by adding a codecov.yaml

Ⅱ. Does this pull request fix one issue?

#124

Ⅲ. Describe how to verify it

check if CI fails when coverage diff is low

Ⅳ. Special notes for reviews

none

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #131 (7e36cb4) into main (d6de2aa) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

❗ Current head 7e36cb4 differs from pull request most recent head 5edd67e. Consider uploading reports for the commit 5edd67e to get more accurate results

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   57.68%   57.33%   -0.35%     
==========================================
  Files          90       78      -12     
  Lines        8056     7376     -680     
==========================================
- Hits         4647     4229     -418     
+ Misses       3004     2765     -239     
+ Partials      405      382      -23     
Flag Coverage Δ
unittests 57.33% <0.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod.go 10.00% <0.00%> (ø)
pkg/koordlet/statesinformer/api.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/koordlet/reporter/config.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/koordlet/statesinformer/config.go 0.00% <0.00%> (-58.34%) ⬇️
pkg/koordlet/statesinformer/kubelet_stub.go 0.00% <0.00%> (-35.30%) ⬇️
pkg/koordlet/statesinformer/states_informer.go 8.21% <0.00%> (-27.50%) ⬇️
...slo-controller/nodemetric/nodemetric_controller.go 53.19% <0.00%> (-7.39%) ⬇️
pkg/koordlet/reporter/reporter.go 1.92% <0.00%> (-4.72%) ⬇️
pkg/koordlet/config/config.go 69.23% <0.00%> (-3.19%) ⬇️
pkg/util/system/util_test_tool.go 53.33% <0.00%> (-2.85%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6de2aa...5edd67e. Read the comment docs.

@saintube saintube force-pushed the add-code-diff-coverage-blocking branch 2 times, most recently from 81153d8 to 5e61917 Compare May 11, 2022 07:25
@koordinator-bot koordinator-bot bot added size/M and removed size/S labels May 11, 2022
@saintube saintube force-pushed the add-code-diff-coverage-blocking branch 16 times, most recently from 83484f9 to 4937603 Compare May 12, 2022 11:44
@saintube saintube changed the title WIP: update codecov configuration update codecov configuration May 12, 2022
@saintube
Copy link
Member Author

/hold

@jasonliu747 jasonliu747 self-assigned this May 23, 2022
@saintube saintube force-pushed the add-code-diff-coverage-blocking branch from 4937603 to 24c0101 Compare May 23, 2022 04:05
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the add-code-diff-coverage-blocking branch from 24c0101 to 5edd67e Compare May 23, 2022 04:10
@saintube
Copy link
Member Author

/hold cancel

@hormes
Copy link
Member

hormes commented May 23, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants