Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(koordlet): support memoryEvictLowerPercent in memory evict #132

Merged
merged 1 commit into from
May 12, 2022

Conversation

shinytang6
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

resolves #85

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #132 (74c8cde) into main (6200cdc) will increase coverage by 0.91%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   56.38%   57.29%   +0.91%     
==========================================
  Files          78       78              
  Lines        7366     7376      +10     
==========================================
+ Hits         4153     4226      +73     
+ Misses       2840     2767      -73     
- Partials      373      383      +10     
Flag Coverage Δ
unittests 57.29% <75.00%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/memory_evict.go 72.07% <75.00%> (+59.20%) ⬆️
pkg/koordlet/resmanager/resmanager.go 56.69% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6200cdc...74c8cde. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, one tiny suggestion.

pkg/koordlet/resmanager/memory_evict.go Outdated Show resolved Hide resolved
Signed-off-by: shinytang6 <1074461480@qq.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented May 12, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7701600 into koordinator-sh:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] koordlet support memoryEvictLowerPercent field in NodeSLO
4 participants