-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support NodeMetricCollectPolicy #157
koordlet: support NodeMetricCollectPolicy #157
Conversation
2460555
to
4860f1c
Compare
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 56.92% 56.86% -0.06%
==========================================
Files 86 87 +1
Lines 7886 7989 +103
==========================================
+ Hits 4489 4543 +54
- Misses 3004 3044 +40
- Partials 393 402 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
697c80f
to
d83f05f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, others PTAL.
d83f05f
to
b55c5d0
Compare
NodeMetricCollectPolicy is used to configure the aggregation period and reporting period. NodeMetric Controller will synchronize the configuration to NodeMetric from the slo-controller-config configuration. Signed-off-by: Tao Li <joseph.t.lee@outlook.com>
b55c5d0
to
0c82cae
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
NodeMetricCollectPolicy is used to configure the aggregation period and
reporting period. NodeMetric Controller will synchronize the configuration
to NodeMetric from the slo-controller-config configuration.
Signed-off-by: Tao Li joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ref #95
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews