Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: introduce cpu evict fields in NodeSLO #161

Merged
merged 1 commit into from
May 24, 2022
Merged

apis: introduce cpu evict fields in NodeSLO #161

merged 1 commit into from
May 24, 2022

Conversation

jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented May 20, 2022

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

This PR introduces

// cpu evict threshold percentage (0,100), default = 70
CPUEvictThresholdPercent *int64 `json:"cpuEvictThresholdPercent,omitempty"`

// if be CPU RealLimit/allocatedLimit > CPUEvictBESatisfactionUpperPercent, then stop evict bepods
CPUEvictBESatisfactionUpperPercent *int64 `json:"cpuEvictBESatisfactionUpperPercent,omitempty"`

// if be CPU (RealLimit/allocatedLimit < CPUEvictBESatisfactionLowerPercent and usage nearly 100%) continue CPUEvictTimeWindowSeconds,then start evict
CPUEvictBESatisfactionLowerPercent *int64 `json:"cpuEvictBESatisfactionUpperPercent,omitempty"`

// cpu evict start after continue avg(cpuusage) > CPUEvictThresholdPercent in seconds
CPUEvictTimeWindowSeconds *int64 `json:"cpuEvictTimeWindowSeconds,omitempty"`

in NodeSLO API. It will later be used for CPU evict feature in Koordlet.

@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng May 20, 2022 15:36
@jasonliu747 jasonliu747 changed the title NodeSLO: introduce cpu evict fields apis: introduce cpu evict fields in NodeSLO May 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #161 (ae63785) into main (49dfdbe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   57.05%   57.05%           
=======================================
  Files          87       87           
  Lines        7989     7989           
=======================================
  Hits         4558     4558           
  Misses       3029     3029           
  Partials      402      402           
Flag Coverage Δ
unittests 57.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49dfdbe...ae63785. Read the comment docs.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@stormgbs
Copy link
Member

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label May 23, 2022
@hormes
Copy link
Member

hormes commented May 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, stormgbs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 27199b9 into koordinator-sh:main May 24, 2022
@jasonliu747 jasonliu747 deleted the nodeslo-api branch May 24, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants