-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: support running unit test on multiple os #162
Conversation
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 57.82% 57.82%
=======================================
Files 91 91
Lines 8159 8159
=======================================
Hits 4718 4718
Misses 3029 3029
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
It might be too slow to run on Mac, can it be made optional? |
/hold |
/hold cancel |
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jason Liu jasonliu747@gmail.com
Ⅰ. Describe what this PR does
Since majority of programmer are using Mac for development, and deploy Koordinator in a Linux environment. So after #151 , I think it's necessary to run github action on multiple environments like MacOS and Linux.
Ⅱ. Does this pull request fix one issue?
fixes #163
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews