-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the runtime-manager design doc #178
Add the runtime-manager design doc #178
Conversation
0e0189d
to
5f02b5b
Compare
4889e05
to
2f6176f
Compare
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 58.66% 58.69% +0.03%
==========================================
Files 94 94
Lines 8615 8615
==========================================
+ Hits 5054 5057 +3
+ Misses 3129 3126 -3
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2f6176f
to
b753b14
Compare
68dd5d7
to
e6cf167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
others PTAL
/cc @hormes @saintube @zwzhang0107 @stormgbs @ZYecho
@jasonliu747: GitHub didn't allow me to request PR reviews from the following users: ZYecho. Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: honpey <honpey@gmail.com>
e6cf167
to
f048962
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: honpey honpey@gmail.com
Ⅰ. Describe what this PR does
fixes #144
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews