Skip to content

Commit

Permalink
Fixed typos
Browse files Browse the repository at this point in the history
  • Loading branch information
JasbirShah committed Aug 7, 2018
1 parent f50423b commit e71c8bf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ I'm really glad you're reading this.

## Merges into higher branches
This section is for merging your changes into the development branch (and later the master branch).
Mke sure you run every unit test in the suite before creating your pull request. We don't want any regressions. Once you've done this, you're good yo make your very own Pull Request!
Make sure you run every unit test in the suite before creating your pull request. We don't want any regressions. Once you've done this, you're good to make your very own Pull Request!

### Creating a Pull Request (PR)
- Merges from any branch into *development* and *master* must go through a GitHub PR.
Expand All @@ -24,5 +24,5 @@ Mke sure you run every unit test in the suite before creating your pull request.
## Coding conventions
I'm hoping you all adhere to these when writing your code. It will increase readability for your reviewers and maintainability later on...
- No single line *if*, *while*, *for*, etc. structures without curly braces. Use curly braces.
- Each method that does not call a subroutine should perform at most 1 function. (eg. A method to translate numbers to excel headers should not be burried within another function, it should be its own)
- Each method that does not call a subroutine should perform at most 1 function. (eg. A method to translate numbers to excel headers should not be buried within another function, it should be its own)
- If your methods are too long, create a private subroutine.

1 comment on commit e71c8bf

@ScottWalkerAU
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can spell good, me.

Please sign in to comment.