Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed to spreadsheet #104

Merged
merged 5 commits into from
Nov 2, 2018
Merged

Bug fixed to spreadsheet #104

merged 5 commits into from
Nov 2, 2018

Conversation

jackratcliffe
Copy link
Collaborator

Fixes issues when copying/pasting empty cells to and from excel and when deleting cells from the spreadsheet.

@jackratcliffe jackratcliffe added bug Something isn't working gui Related to the graphical user interface. labels Nov 1, 2018
@jayden626
Copy link
Collaborator

jayden626 commented Nov 1, 2018

@jackratcliffe
-Pasting missing values from excel into ICONIC won't overwrite nonnull values
e.g. if Iconic has a dataset in it 1,2,,4 and we copy 1,,3,4 from Excel, we will get 1,2,3,4 instead of the 1,,3,4 that was pasted

Delete context menu button doesn't delete selected cells
Saw you added this (I think), but it's not working. I don't care too much
EDIT: I was looking at the menu bar, not the right click context menu. Context menu works as expected

P.s. can you sneak this in: Context menu > Help states "About Ionic Workbench". Please fix the spelling error to say "About Iconic Workbench"
Change version number to 0.7.0 and add a link to the repo in the help dialog

Copy link
Collaborator

@jayden626 jayden626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See pull request comments

@jackratcliffe
Copy link
Collaborator Author

fixed the missing values not overwriting issue, added top menu bar functionality and updated the about dialogue

@jayden626 jayden626 merged commit be462a3 into develop Nov 2, 2018
@jayden626 jayden626 deleted the feature/spreadsheetfixes branch November 2, 2018 01:19
@jayden626 jayden626 added this to the 0.7.0 milestone Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui Related to the graphical user interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants