Add Chromosome Factories #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: added a base factory class for producing chromosomes and a factory for expression chromosomes. Refactor: changed existing classes to use chromosome factories.
JasbirShah
added
api
Refactor: changed the method for adding functional primitives to a chromosome factory to accept a variable number of arguments.
Documentation: documented most of the ExpressionChromosomeFactory class Refactor: changed ChromosomeFactory::addFunction to accept a list and refactored all users of the method. Bugfix: ChromosomeFactory::addFunction was attempting to add functions to a clone instead of the actual class member.
Documentation: feeatures are like better features, but we're saving those for Iconic Plus.
Testing: ExpressionChromosomeFactory now has a test suite and ExpressionChromosome's test has been updated for easier reuse. Documentation: added some brief documentation to all the tests.
ScottWalkerAU
requested review from
ScottWalkerAU
and removed request for
ScottWalkerAU
JasbirShah
requested review from
ScottWalkerAU
and removed request for
koosvary
ScottWalkerAU
approved these changes
Aug 7, 2018
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add appropriate factories for existing chromosome types in the application and refactors existing classes to use them as per the design documents.