Implementation of the Pivot table component #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 25, 2023 14:31
Pivot Table : Add help popup Pivot Table : Add Aggregator function
Ajouter un message lors de la régénération du table pivot Corriger l'ordre des colonnes lors de la régénération du table pivot
mgrati
requested changes
Nov 9, 2023
galite-core/src/main/kotlin/org/kopi/galite/visual/domain/Domain.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/domain/Domain.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/domain/Domain.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/dsl/form/DictionaryForm.kt
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/ui/vaadin/pivotTable/DPivotTable.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/ui/vaadin/pivotTable/DPivotTable.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/ui/vaadin/pivotTable/DPivotTable.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/ui/vaadin/pivotTable/DPivotTable.kt
Outdated
Show resolved
Hide resolved
galite-demo/galite-vaadin/src/main/kotlin/org/kopi/galite/demo/bill/BillForm.kt
Outdated
Show resolved
Hide resolved
mgrati
requested changes
Nov 23, 2023
There was a problem hiding this comment.
I added few code style comments below. Please check.
The task ./gradlew test is failed. please check and fix the failed tests. The failed test is in Class org.kopi.galite.tests.ui.vaadin.form.FormTests and it is caused by the changes in Migration.addProducts. You can fix it by extracting the first 4 records of the loop and start your loop from 4
I also think that some changes need to be done for Galite demo :
- The products pivot table is OK, However, the pivot tables added for clients or bill products I don't find particularly meaningful.
- For the client pivot table, I suggest that you add a left join with the table purchase and maybe product so you can add quantity and price as measures. and at the same time check if dimensions and measures can accept null values.
- I think we can delete the bill product pivot table since it's not really meaningful
galite-core/src/main/kotlin/org/kopi/galite/visual/dsl/pivottable/Dimension.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/dsl/pivottable/PivotTable.kt
Outdated
Show resolved
Hide resolved
Comment on lines
2
to
3
| * Copyright (c) 2013-2022 kopiLeft Services SARL, Tunis TN | ||
| * Copyright (c) 1990-2022 kopiRight Managed Solutions GmbH, Wien AT |
galite-core/src/main/kotlin/org/kopi/galite/visual/pivottable/Constants.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/pivottable/VPivotTable.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/pivottable/VPivotTable.kt
Outdated
Show resolved
Hide resolved
galite-core/src/main/kotlin/org/kopi/galite/visual/pivottable/VPivotTableColumn.kt
Show resolved
Hide resolved
mgrati
approved these changes
Nov 24, 2023
RiadhCherni
pushed a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pivot table component to Galite