Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Chart in Galite #APPS-01WNA #620

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Implementation Chart in Galite #APPS-01WNA #620

merged 6 commits into from
Feb 19, 2024

Conversation

Iyedchaabane
Copy link
Contributor

Implementation Chart in Galite

Copy link
Member

@RiadhCherni RiadhCherni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'odre des imports dans tous les class
Je propose de supprimer les class : VChartCommand, VDefaultChartActor et VPrintOptions
UChartType.kt : Supprimer les méthodes d'exports , je propose aussi de supprimer la fonction refresh()
VDecimalCodeDimension.kt : ajouter la description du format

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'ordre des imports et supprimer les imports innuties.
Merci de supprimer les commandes d'export crée dans Galite; on va utilisé les méthodes exports définit dans le composant ApexChart
Supprimer l'heritage du class Printable
Supprimer les constantes TYP_PDF ...
Supprimer le constante printOptions
Changer le commentaire " Localizes this report "
Supprimer la fonction createPrintJob()
Supprimer la fonction getDocumentType() [ changer le commentaire ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'odre des imports

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'odre des imports et supprimer les imports inutiles
Supprimer ce commentaire "// FIXME: temporary styling"
Supprimer les fonctions d'exports
check fonction : randomAdditionalColor()
je propose de supprimer la fonction createChartData()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fonction createChartData() peut être supprimée, car le traitement est effectué dans la classe DAbstractChartType

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fonction createChartData() peut être supprimée, car le traitement est effectué dans la classe DAbstractChartType

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fonction createChartData() peut être supprimée, car le traitement est effectué dans la classe DAbstractChartType

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fonction createChartData() peut être supprimée, car le traitement est effectué dans la classe DAbstractChartType

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fonction createChartData() peut être supprimée, car le traitement est effectué dans la classe DAbstractChartType

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supprimer les imports inutiles et corriger l'ordre des imports
ce trigger ne fonctionne pas
color {
VColor.GREEN
}

@mgrati mgrati merged commit 39d8372 into master Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants