Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the value type of the color field to an integer instead of hexadecimal [APPS-02A8] #631

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Convert the value type of the color field to an integer instead of hexadecimal [APPS-02A8] #631

merged 5 commits into from
Aug 16, 2024

Conversation

achraf-dridi
Copy link

Convert the value type of the color field to an integer instead of hexadecimal [APPS-02A8]

mgrati
mgrati requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@mgrati mgrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to create a new SQL type Table.color in org.kopi.galite.database.Types.kt. As such, we can encapsulate the color fields in the database as well as the Galite forms

mgrati
mgrati requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@mgrati mgrati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions to improve the changed made in galite-demo.

Other thing : The forms Command & Bills do not work with Locale FR_fr. This should be fixed.

galite-demo/galite-vaadin/src/main/kotlin/org/kopi/galite/demo/command/CommandForm.kt Show resolved Hide resolved
galite-demo/galite-vaadin/src/main/kotlin/org/kopi/galite/demo/database/Migration.kt Outdated Show resolved Hide resolved
galite-demo/galite-vaadin/src/main/kotlin/org/kopi/galite/demo/database/Migration.kt Outdated Show resolved Hide resolved
@mgrati mgrati merged commit be1b2d0 into master Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrati mgrati Awaiting requested review from mgrati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achraf-dridi @mgrati