-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Add multi-language support for kopia-ui #241
base: main
Are you sure you want to change the base?
Conversation
This is promising, i took it for a quick spin. Some first impressions/questions/ideas:
|
… into add-language-support
@lupusA this is looking very nice, I found a few minor things:
|
@@ -0,0 +1,96 @@ | |||
{ | |||
"tab.preferences": "Preferencias", | |||
"tab.repository": "Repositorio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tab.repository": "Repositorio", | |
"tab.repository": "Depósito", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess either one works.
"tab.repository": "Repositorio", | ||
"tab.tasks": "Tareas", | ||
"tab.policies": "Políticas", | ||
"tab.snapshots": "Instantáneas", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what a good word would be here, but "Instantáneas" does not work.
I would probably say something like "copias de respaldo"
"snapshot.header.snapshot.next": "Siguiente instantánea", | ||
"snapshot.header.snapshot.last": "Última instantánea", | ||
"snapshot.header.snapshot.size": "Tamaño", | ||
"snapshot.header.snapshot.owner": "Propietario", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is shorter
"snapshot.header.snapshot.owner": "Propietario", | |
"snapshot.header.snapshot.owner": "Dueño", |
|
||
"user.interface": "Interfaz de usuario", | ||
"user.interface.appearance": "Apariencia", | ||
"user.interface.appearance.hint": "Selecciona el tamaño de fuente", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"user.interface.appearance.hint": "Selecciona el tamaño de fuente", | |
"user.interface.appearance.hint": "Selecciona el tamaño de letra", |
"repository.event.connection.disconnect": "Desconectar del repositorio", | ||
"repository.event.description.update": "Actualizar descripción", | ||
"repository.feedback.description.required": "La descripción del repositorio es obligatoria", | ||
"repository.feedback.read.only": "El repositorio es de solo lectura", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"repository.feedback.read.only": "El repositorio es de solo lectura", | |
"repository.feedback.read.only": "El repositorio es de sólo lectura", |
There are a couple of things that aren't perfect right now. I will try to fix them first and add them to the list. Cheers, |
…ant code change anymore.
Could you kindly consider adding support for Korean as well? I'll be responsible for translating into Korean. |
Hi @NavyStack, supporting additional languages will be easy. You just have to create a PR with the translation and a little adjustment to the language.json file. Thats all :-) |
Thanks! I will make a PR soon. |
By the way, japenese will be added in the initial commit. But it will be a machine-based translation :-) Cheers, |
考虑中文么 |
I can be responsible for translating Simplified Chinese. |
I will work on it again next week. I am currently busy in private matters. I need to refactor the translation keys again, to provide a good basis for further translations. @NavyStack |
@lupusA , Cheers. |
@lupusA I will be reset hard from English key. |
I think naming needs to follow certain international norms because a language may have multiple variants for example, English -> en-US / en-UK |
Hi,
this PR adds the multi-language support feature to
kopia-ui
. Users can select their language in the preference tab.The following languages are supported:
This PR also adds new libaries and dependencies (i18next, react-i18next, i18next-http-backend)
The PR will close kopia/kopia#3708 and has a dependency to kopia/kopia#3768.
Tasks to be resolved:
Cheers,